-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIPの質問は未解決一覧には含めず、全ての質問一覧にだけ含める #4604
Merged
komagata
merged 2 commits into
main
from
feature/wip-questions-are-not-included-in-the-list-of-unresolved-questions
Apr 17, 2022
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -293,15 +293,21 @@ class QuestionsTest < ApplicationSystemTestCase | |
assert_selector '.thread-header-title__label.is-wip', text: 'WIP' | ||
end | ||
|
||
test 'show a WIP question on the Q&A list page' do | ||
visit_with_auth questions_path, 'kimura' | ||
test 'show a WIP question on the All Q&A list page' do | ||
visit_with_auth questions_path(all: 'true'), 'kimura' | ||
assert_text 'wipテスト用の質問(wip中)' | ||
element = all('.thread-list-item').find { |component| component.has_text?('wipテスト用の質問(wip中)') } | ||
within element do | ||
assert_selector '.thread-list-item-title__icon.is-wip', text: 'WIP' | ||
end | ||
end | ||
|
||
test 'not show a WIP question on the unsolved Q&A list page' do | ||
visit_with_auth questions_path, 'kimura' | ||
assert_no_text 'wipテスト用の質問(wip中)' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
同じです! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. こちら、「未解決の質問一覧」の文言が表示されていることの検証も追加してみました。 |
||
assert_text '未解決の質問一覧' | ||
end | ||
|
||
test "visit user profile page when clicked on user's name on question" do | ||
visit_with_auth questions_path, 'kimura' | ||
assert_text '質問のタブの作り方' | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
何かがないことをテストする際は、そのページ特有のものがあることを一緒にアサーションしたほうがよいかなと思いました。
参考 : システムスペックやフィーチャスペックで「〜が表示されないこと」だけを検証するのはちょっと危険、という話 - Qiita
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご指摘ありがとうございます!こちら、「未解決」のラベルがアクティブになっていることの検証も追加してみました。