Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2022-04-21 11:15:40 #4627

Merged
merged 91 commits into from
Apr 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
8ec8567
カレンダーで日付を指定して新規のreport作成画面を開く
NorifumiOgawa Apr 2, 2022
04500dc
日付がない日はリンクしない
NorifumiOgawa Apr 3, 2022
53eb7c8
テストを追加
NorifumiOgawa Apr 4, 2022
799a82d
検索結果一覧でWIPの日報やDocsを識別できるようにした
eatplaynap Mar 25, 2022
cac39bb
lint通過
eatplaynap Mar 25, 2022
99a0b48
searchableClass内の条件分岐を簡略化
eatplaynap Mar 31, 2022
03c3f45
リファクタリング
eatplaynap Mar 31, 2022
50d27d1
helperメソッドをjbuilder内の処理に書き換え
eatplaynap Apr 4, 2022
d23e9fb
searchableがwipというメソッドを持っていることを明示するため使用メソッドを変更
eatplaynap Apr 4, 2022
85e35c6
使っていないcomputed propertyを削除
eatplaynap Apr 7, 2022
db40874
booleanを扱っていることを明示するため?を追記
eatplaynap Apr 7, 2022
d065497
項目自体を表示しないのではなく、falseを出すようにした
eatplaynap Apr 8, 2022
d2288fb
テストにカレンダーの日付リンクをクリックしたときの動作を追加
NorifumiOgawa Apr 11, 2022
69f044f
lintの修正追加
NorifumiOgawa Apr 11, 2022
4105dff
卒業生のダッシュボードには「卒業後の目標」の入力を促すブロックを出さないようにした
siroemk Apr 9, 2022
fefb2db
卒業生のダッシュボードのテストを追加した
siroemk Apr 9, 2022
efa2f43
graduated?を使うように修正した
siroemk Apr 12, 2022
376648d
テストの名前を修正した
siroemk Apr 12, 2022
9e8b625
WIPの質問を未解決に表示しない
NorifumiOgawa Apr 12, 2022
e39894a
ユーザーが退会した時にメンターにも通知とメールが届くようにした
siroemk Apr 12, 2022
125c3d5
テストにメンターへの通知を追加した
siroemk Apr 12, 2022
741ba66
graduated?からgraduatedに修正した
siroemk Apr 12, 2022
7c6f491
「〜が表示されない」テストの改善
NorifumiOgawa Apr 13, 2022
30b15f4
ニコニコカレンダーのリンクにデザインを入れた
machida Apr 13, 2022
1dd826a
プラクティス共通の説明のDocがWIPの場合は、詳細画面に表示しないように修正
tksmasaki Apr 14, 2022
e666ff5
border色の変数の設定を変更
machida Apr 15, 2022
64d5bb4
管理者・メンターはブログを修正・削除できるようにした
niikz Apr 12, 2022
b45dcb0
ブログ記事の個別ページで編集・削除ボタンの表示を確認するテストを追加
niikz Apr 12, 2022
33bf031
管理者・メンターはブログを修正・削除できることを確認するテストを追加
niikz Apr 12, 2022
676e7e0
テストの文言を修正
niikz Apr 15, 2022
bf548f6
プラクティス選択プルダウンをChoices.jsに変更
NorifumiOgawa Apr 15, 2022
4517a82
Merge pull request #4624 from fjordllc/border-color
machida Apr 15, 2022
46e3410
prettier対応修正
NorifumiOgawa Apr 15, 2022
0f146a4
コメントアウト行を削除
NorifumiOgawa Apr 15, 2022
d7a43bc
Merge pull request #4501 from fjordllc/feature/identify-wip-from-sear…
komagata Apr 17, 2022
53eeb42
Merge pull request #4597 from fjordllc/feature/fix-graduate-dashbord
komagata Apr 17, 2022
2cc338f
ユーザー情報変更ページの管理者が変更できる項目に、コースを追加
Saki-htr Apr 7, 2022
41f5e07
不要な{}を削除
Saki-htr Apr 9, 2022
e552597
管理者が登録情報変更ページで、コース変更できることを確認するテストを追加
Saki-htr Apr 10, 2022
1a89100
findよりreloadを使ったほうが、シンプルかつuserのデータを再読み込みしているとすぐに理解できるため、変更
Saki-htr Apr 12, 2022
935a07a
Choices-jsを使って、インクリメンタルサーチできる仕様にする際に必要になるため、{}を再追加
Saki-htr Apr 12, 2022
16b7905
管理者以外の一般ユーザーは、ユーザーのコースを変更できないテストを追加
Saki-htr Apr 17, 2022
eae4957
Merge pull request #4604 from fjordllc/feature/wip-questions-are-not-…
komagata Apr 17, 2022
709928c
Merge pull request #4619 from fjordllc/bug/not-show-practice-common-d…
komagata Apr 17, 2022
4d4d8c6
Merge pull request #4605 from fjordllc/feature/notify-mentor-when-use…
komagata Apr 17, 2022
de027c6
Merge pull request #4596 from fjordllc/feature/enable-change-courses-…
komagata Apr 17, 2022
7c5e4b1
wip中の質問の表示タブが変わったことに対応させた
Paru871 Apr 17, 2022
5a39c88
Merge pull request #4635 from fjordllc/bug/fix-system-questions-test
komagata Apr 18, 2022
4ec09cc
companies-products.vueを作成
clio209 Mar 27, 2022
a39ff55
コンフリクトの解消
clio209 Apr 17, 2022
cc0c98b
apiコントローラー staff限定ログインを非限定に変更
clio209 Apr 4, 2022
dc00bf7
コンフリクトの解消
clio209 Apr 14, 2022
7c05f27
コンフリクトの解消
clio209 Apr 14, 2022
8c9bdc2
rubocop修正
clio209 Apr 6, 2022
f88bf37
Prettier 修正
clio209 Apr 6, 2022
01c9b5a
インデント変更
clio209 Apr 11, 2022
8a3fb70
インデント、不必要なメソッドの一部を削除
clio209 Apr 14, 2022
5646ab6
不必要なメソッドの一部を削除
clio209 Apr 14, 2022
f985538
prettier 修正
clio209 Apr 14, 2022
e2b18f8
コンフリクトの解消
clio209 Apr 17, 2022
df60ae1
rubocop 修正
clio209 Apr 17, 2022
4b67190
カード情報・編集ページを削除
komagata Apr 18, 2022
fef530e
Merge pull request #4640 from fjordllc/feature/remove-link-for-card
komagata Apr 18, 2022
cf23654
コンフリクトの解消
clio209 Apr 14, 2022
f081ab8
prettier 修正
clio209 Apr 8, 2022
55662fc
生徒のナビからにもanchorが付くように追記
clio209 Apr 11, 2022
d4f7971
rubocop修正
clio209 Apr 11, 2022
4db6652
@company に存在するときのみの条件を追加
clio209 Apr 18, 2022
8b1629c
カテゴリー並び替えで空のスラッグの行を削除した
siroemk Apr 18, 2022
557d9ee
コメントがない場合もアンカーが付くように修正
clio209 Apr 18, 2022
78b389e
traineeの場合、sign_upフォームに企業選択項目が出るように変更
clio209 Apr 18, 2022
252aa2a
traineeのsign_upテストでcompany_idを振る
clio209 Apr 18, 2022
5ad3d36
不要な変更の修正
clio209 Apr 18, 2022
eb4d97c
相談ボタンを全員に表示
Nabegon Apr 1, 2022
0717290
Choices.jsのデザインを調整
machida Apr 20, 2022
2c9bbf3
Merge pull request #4608 from fjordllc/feature/allow-administrators-a…
komagata Apr 20, 2022
8bffcba
Merge pull request #4550 from fjordllc/feature/niconico-calendar-new-…
komagata Apr 20, 2022
ac586a8
Merge pull request #4549 from fjordllc/feature/convert-companies-prod…
komagata Apr 20, 2022
a5acc59
Merge pull request #4592 from fjordllc/feature/add_scroll_down_to_lat…
komagata Apr 20, 2022
e1d14fb
Merge pull request #4645 from fjordllc/bug/display-consultation-butto…
komagata Apr 20, 2022
2ad0793
Merge pull request #4639 from fjordllc/bug/delete-slug-from-category
komagata Apr 20, 2022
d3e0d9d
Merge pull request #4626 from fjordllc/feature/replace-practice-selec…
komagata Apr 20, 2022
9f11fb6
choices-js-cssのデザイン崩れ修正
machida Apr 20, 2022
a15d69e
Merge pull request #4654 from fjordllc/choices-js-css
machida Apr 20, 2022
b79a2e3
WIP
machida Apr 20, 2022
f11b043
product個別ページのデザインリニューアル
machida Apr 21, 2022
a3f1ec2
Merge pull request #4657 from fjordllc/new-product
machida Apr 21, 2022
f57b962
提出物個別ページのタイトルの微調整
machida Apr 21, 2022
cb722c4
Merge pull request #4659 from fjordllc/fix-product-title
machida Apr 21, 2022
00242b0
提出物のカードのタイトルを小さくした
machida Apr 21, 2022
cad3883
Merge pull request #4663 from fjordllc/product-card-title-size
machida Apr 21, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/stylesheets/_common-imports.sass
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
@import "variables/welcome-colors"
@import "variables/layout"
@import "variables/fonts"
@import "variables/choices"

////////////
// mixins
Expand Down
5 changes: 5 additions & 0 deletions app/assets/stylesheets/atoms/_a-badge.sass
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
color: $muted-text
font-weight: 400
background-color: $background
&.is-dark-muted
border: none
color: $semi-muted-text
font-weight: 400
background-color: $background-shade

//size
&.is-xs
Expand Down
16 changes: 15 additions & 1 deletion app/assets/stylesheets/atoms/_a-card.sass
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.a-card
background-color: $base
border-radius: .25rem
border: solid 1px $border-more-shade
border: solid 1px $border-shade
+margin(horizontal, auto)
+media-breakpoint-down(lg)
&:not(:last-child)
Expand All @@ -21,6 +21,20 @@
max-width: 100%
+media-breakpoint-down(sm)
+margin(horizontal, 1rem)
&.is-toggle
label
cursor: pointer
> input:not(:checked) + * + *
display: none
> input:not(:checked) + *
border-bottom: none
> input:checked + * + *
display: block
> input:not(:checked) + * .is-hidden-then-unchecked
display: none
> input:checked + * .is-hidden-then-checked
display: none


.a-card-notice
p
Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/atoms/_a-file-input.sass
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
max-height: 100%
max-width: 100%
object-fit: contain
border: solid 1px $background
border: solid 1px $border-tint
input
overflow: hidden
+size(0)
Expand Down
2 changes: 2 additions & 0 deletions app/assets/stylesheets/atoms/_a-short-text.sass
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@
border: none
border-top: dashed 1px $border
+margin(vertical, 1.25em)
&.is-ta-center
text-align: center
2 changes: 1 addition & 1 deletion app/assets/stylesheets/atoms/_a-text-input.sass
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.a-text-input
+text-block(1em 1.45, block)
background-color: #fafafa
background-color: $input-background
width: 100%
padding: .5rem
border: solid 1px $input-border
Expand Down
21 changes: 21 additions & 0 deletions app/assets/stylesheets/atoms/_a-title-label.sass
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
.a-title-label
+text-block(.5em 1, flex nowrap 0)
background-color: #e9ebef
+padding(horizontal, 1em)
border-radius: .75rem
align-items: center
+position(relative, top .75em)
margin-right: .5em
+media-breakpoint-up(md)
height: 1.5em
+position(top .75em)
+media-breakpoint-down(sm)
font-size: .625rem
height: 1.75em
+position(top .375em)
&.is-solved
color: $reversal-text
&.is-success
background-color: $success
&.is-danger
background-color: $danger
1 change: 1 addition & 0 deletions app/assets/stylesheets/atoms/_a-user-name.sass
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
font-size: .8125rem
line-height: 1.4
white-space: nowrap
font-weight: 400
.thread-list-item-name &
font-size: .75rem

Expand Down
4 changes: 2 additions & 2 deletions app/assets/stylesheets/blocks/auth-form/_auth-form.sass
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@
margin-top: 2rem

.auth-form__header
border-bottom: solid 1px $background
border-bottom: solid 1px $border-tint
padding: 1rem 1.25rem

.auth-form__body
padding: 1.5rem 1.25rem

.auth-form__footer
border-top: solid 1px $background
border-top: solid 1px $border-tint
padding: 1rem 1.25rem

.auth-form__title
Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/blocks/card/_card-body.sass
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
+media-breakpoint-down(sm)
padding: .75rem
&:not(:last-child)
border-bottom: solid 1px $background
border-bottom: solid 1px $border-tint
p
+text-block(1em 1.6)
2 changes: 1 addition & 1 deletion app/assets/stylesheets/blocks/card/_card-books.sass
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
max-width: 100%
object-fit: contain
object-position: 50% 0
border: solid 1px $background
border: solid 1px $border-tint
border-radius: 2px

.card-books-item__description
Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/blocks/card/_card-footer.sass
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.card-footer
border-top: $background solid 1px
border-top: solid 1px $border-tint
+media-breakpoint-up(md)
padding: .75rem 1.25rem
+media-breakpoint-down(sm)
Expand Down
8 changes: 6 additions & 2 deletions app/assets/stylesheets/blocks/card/_card-header.sass
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.card-header
border-bottom: solid 1px $background
border-bottom: solid 1px $border-tint
padding: .75rem 1.25rem
display: flex
align-items: center
Expand All @@ -16,7 +16,11 @@
margin-top: -1px

.card-header__title
+text-block(1rem 1.4, 600)
+text-block(1em 1.4, 600)
+media-breakpoint-up(md)
font-size: 1rem
+media-breakpoint-down(sm)
font-size: .875rem
.card-header.is-sm &
font-size: .875rem

Expand Down
4 changes: 2 additions & 2 deletions app/assets/stylesheets/blocks/card/_card-list.sass
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@

.card-list__items
.card-list__deacription + &
border-top: dotted .0625rem $background
border-top: dotted .0625rem $border-tint

.card-list__item:not(:last-child)
border-bottom: dotted .0625rem $background
border-bottom: dotted .0625rem $border-tint

.card-list__item-link
+text-block(.8125rem 1.6, block $main)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

.congrats-card-body__image
border-radius: .75rem
border: solid .5rem $background
border: solid .5rem $border-tint

.congrats-card-body
.card-main-actions
Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/blocks/entry/_entry-header.sass
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
margin-bottom: 1.5rem
+padding(horizontal, 1.25rem)
+padding(vertical, 1rem)
border-bottom: solid 1px $background
border-bottom: solid 1px $border-tint
+media-breakpoint-down(sm)
+padding(horizontal, 1rem)
margin-bottom: 1rem
Expand Down
6 changes: 3 additions & 3 deletions app/assets/stylesheets/blocks/header/_header-dropdown.sass
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
+media-breakpoint-up(md)
color: $default-text
.header-dropdown__item:not(:last-child) &
border-bottom: solid 1px $background
border-bottom: solid 1px $border-tint
&:hover
background-color: $background-tint
+media-breakpoint-down(sm)
Expand All @@ -74,7 +74,7 @@
+border-radius(bottom, .25rem)
overflow: hidden
+media-breakpoint-up(md)
border-top: solid 1px $background
border-top: solid 1px $border-tint
+media-breakpoint-down(sm)
border-top: solid 1px $side-border

Expand All @@ -97,7 +97,7 @@
background-color: $side-shade
+media-breakpoint-up(md)
&:not(:last-child)
border-bottom: solid 1px $background
border-bottom: solid 1px $border-tint
+media-breakpoint-down(sm)
border-bottom: solid 1px $side-border

Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/blocks/header/_header-links.sass
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
.header-links__item
display: flex
height: 100%
border-left: solid $background .0625rem
border-left: solid $border-tint .0625rem
+position(relative)
transition: color .2s ease-in, background-color .2s ease-in

Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/blocks/header/_header.sass
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.header
background-color: $base
z-index: 3
border-bottom: solid 1px $background
border-bottom: solid 1px $border-tint
+media-breakpoint-up(md)
+position(sticky, top 0)
+media-breakpoint-down(sm)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
padding-top: .5rem
+margin(horizontal, -1rem)
+padding(horizontal, 1rem)
border-top: solid 1px $background
border-top: solid 1px $border-tint

.page-header-actions__items
display: flex
Expand Down
6 changes: 3 additions & 3 deletions app/assets/stylesheets/blocks/page/_page-tabs.sass
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
background-color: $background-shade
padding-top: .5rem
border-top: solid 1px $border-shade
border-bottom: solid 1px $border-more-more-shade
border-bottom: solid 1px $border-more-shade
.sort-nav + &
border-top: solid 1px $border-more-more-shade
.page-header + &
Expand All @@ -28,10 +28,10 @@
align-items: center
justify-content: center
height: 2.75rem
background-color: #dedede
background-color: #dfdfe5
+padding(horizontal, 1em)
+border-radius(top, .25rem)
border: solid 1px $border-more-more-shade
border: solid 1px $border-more-shade
+position(relative)
transition: all .2s ease-out
+media-breakpoint-down(sm)
Expand Down
6 changes: 1 addition & 5 deletions app/assets/stylesheets/blocks/practice/_categories.sass
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,8 @@
+media-breakpoint-down(sm)
margin-bottom: 2rem

.categories-item__anchor
+media-breakpoint-up(md)
+position(relative, top -3.5rem)

.categories-item__title
+text-block(1.5rem 1.5, $main-text 600)
+text-block(1.5rem 1.5, $main-text 700)
position: relative
+media-breakpoint-down(sm)
font-size: 1.25rem
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
.category-practices-item
padding: .75rem 1rem
border-bottom: solid 1px $background
border-bottom: solid 1px $border
+position(relative)
&:last-child
border-bottom: none
&:nth-child(odd)
background-color: #fafafa
&:nth-child(even)
background-color: $background-more-tint
+media-breakpoint-down(sm)
flex-wrap: wrap
padding: .5rem .75rem .75rem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
padding-bottom: .25rem

.practice-contents__title
+text-block(1.5rem 1.4, 600 $side)
+text-block(1.5rem 1.4, 700 $side)
+media-breakpoint-down(sm)
font-size: 1.25rem
word-break: break-all
Expand Down
59 changes: 59 additions & 0 deletions app/assets/stylesheets/blocks/product/_product-header.sass
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
.product-header
+media-breakpoint-up(md)
display: flex
margin-bottom: 2rem
.a-user-name
+media-breakpoint-down(sm)
display: block
text-align: center
margin-bottom: .5rem

.product-header__start
+media-breakpoint-up(md)
flex: 0 0 5rem

.product-header__end
+media-breakpoint-up(md)
flex: 1
+media-breakpoint-down(sm)
margin-top: .5rem

.product-header__user
+media-breakpoint-down(sm)
display: flex
justify-content: center

.product-header__user-link
+block-link

.product-header__user-icon
+size(3.5rem)

.product-header__title
font-feature-settings: "palt"
letter-spacing: .02em
+text-block(1em 1.45, 700 $main)
padding-bottom: .25rem
border-bottom: solid 1px $border-shade
+media-breakpoint-up(md)
font-size: 1.5rem
margin-top: .125rem
+media-breakpoint-down(sm)
font-size: 1.125rem
margin-top: .125rem
word-break: break-all
&.is-wip
color: $muted-text
.a-title-label
display: inline-flex
vertical-align: top
+media-breakpoint-up(md)
+position(relative, top .75em)
+media-breakpoint-down(sm)
+position(relative, top .5em)

.product-header__title-link
+hover-link
color: $main
.product-header__title.is-wip &
color: $muted-text
13 changes: 13 additions & 0 deletions app/assets/stylesheets/blocks/product/_product.sass
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
.product
+position(relative)
+margin(horizontal, auto)
+media-breakpoint-up(md)
width: $thread-max-width
max-width: 100%
.a-watch-button.is-inactive,
.a-bookmark-button.is-inactive
color: $semi-muted-text
background-color: $background-shade
.a-title-label
color: $semi-muted-text
background-color: $background-shade
Loading