Q&Aを削除する際に表示する確認ダイアログの文言を変更 #4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Saki-htr |
komagata
reviewed
Jun 15, 2022
| @@ -394,4 +394,11 @@ class QuestionsTest < ApplicationSystemTestCase | |||
| end | |||
| assert_link 'Linuxのファイル操作の基礎を覚える' | |||
| end | |||
|
|
|||
| test 'show confirm dialog before delete' do | |||
There was a problem hiding this comment.
これってassertがひとつもないような感じなのですが、それだとチェックになってないかもです〜
There was a problem hiding this comment.
なるほどです。
私もassertが0なのは気になったのですが、確認ダイアログが空文字だったり、文言が異なっていると下記のようにエラーでテストが落ちるので、dismiss_confirmでテスト出来ていると考えたのですが、assertを使ったテストの方が良いでしょうか。
|
@komagata |
komagata
reviewed
Jun 21, 2022
ai-24
force-pushed
the
feature/change-confirm-prompt-to-delete-question
branch
from
ce95f6d to
102f977
Compare
|
@komagata
今までテストの失敗とエラーの違いがあまりよく理解できていなかったと思います。 テストにassertionを追加いたしましたので、再度ご確認いただけますでしょうか。 |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
Q&Aを削除する際に表示する確認ダイアログの文言を変更しました。
変更確認方法
feature/change-confirm-prompt-to-delete-questionをローカルに取り込みますbin/rails sでローカル環境を立ち上げます変更前
変更後