-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
「読みました」のチェックボックスを埋めたら「休会する」ボタンを押せるようにした #5461
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6b74788
メンターが提出物のコメントフォームから確認okにした時のトーストが正しく表示されるようにした
keiz1213 073ee4f
lint修正
keiz1213 0e27b25
createCommentの引数修正と条件式の切り出し
keiz1213 6dd821b
createCommentのデフォルトの引数を変更
keiz1213 358cc07
休会チェックボックスのデザイン
machida 39435ff
:cop:
machida 22bea4c
休会フォームの注意を「読みました」のチェックボックスとボタンが連動するようにした
b81f5d2
テストを修正
5cfd3a6
テストのチェックボックスを確認するメソッドをcapybaraのものにした
598e5d4
テストのチェックボックスを確認するメソッドをcapybaraのものにした(修正漏れの対応)
b5d4e52
日付を超えたらテストが落ちるようになってしまったので修正した
169b029
テストが通らなくなったのでチェックボックスのメソッドを修正した
1676ce0
html内のidを変更
b4f3f09
テストで使用するクラス名を具体的にした
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
document.addEventListener('DOMContentLoaded', () => { | ||
const checkbox = document.querySelector('.js-hibernation-agreements-checkbox') | ||
const submit = document.querySelector('.js-hibernation-agreements-submit') | ||
|
||
checkbox.addEventListener('change', () => { | ||
if (checkbox.checked) { | ||
submit.classList.remove('is-disabled') | ||
submit.classList.add('is-danger') | ||
} else { | ||
submit.classList.add('is-disabled') | ||
submit.classList.remove('is-danger') | ||
} | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍