Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gemの並び順をアルファベット順にした #5593

Closed
wants to merge 1 commit into from
Closed

gemの並び順をアルファベット順にした #5593

wants to merge 1 commit into from

Conversation

shibaaaa
Copy link
Contributor

概要

ref: https://app.circleci.com/pipelines/github/fjordllc/bootcamp/3683/workflows/b1ac2499-4d26-4139-8413-b6414f7b48fa/jobs/8987

Gemfile:67:3: C: [Correctable] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem pry-byebug should appear before syntax_suggest.
  gem 'pry-byebug'
  ^^^^^^^^^^^^^^^^

@shibaaaa
gemの並び順をアルファベット順にした
e26e0b3 
rubocop Bundler/OrderedGemsへの対応のため
@shibaaaa
Copy link
Contributor Author

@komagata
Gemfile内の並び順でrubocopに怒られるようになってしまっていたので修正しました:bow:
レビューお願いします:pray:

@machida machida requested a review from komagata September 26, 2022 15:55
@machida machida mentioned this pull request Sep 26, 2022
Merged
@shibaaaa
Copy link
Contributor Author

#5595 で対応されたのでこちらはクローズしますー

@shibaaaa shibaaaa closed this Sep 26, 2022
@shibaaaa shibaaaa deleted the fix_gem_sort branch September 26, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komagata komagata Awaiting requested review from komagata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shibaaaa