-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Q&A個別ページに同プラクティス関連Q&A一覧を追加する #6135
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
88254b6
プラクティスの質問を取得し表示する
futa4095 656fb41
テストを追加
futa4095 21fb9e5
Q&A個別ページの右カラムにデザインを入れた
machida 1fac3c3
デザイン変更に伴うテスト修正
machida 306f516
bullet gem対応 不要なinclude(:user)を削除
futa4095 c84f7ac
デザインに合わせてテストを変更
futa4095 9a84752
質問一覧をパーシャルに分離する
futa4095 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
ul.page-nav__items | ||
- questions.each do |question| | ||
li.page-nav__item(class="#{@question == question ? 'is-current' : ''}") | ||
= link_to question_path(question), class: 'page-nav__item-link has-metas' do | ||
.page-nav__item-link-inner | ||
.page-nav__item-header | ||
- unless question.correct_answer | ||
.a-badge.is-danger.is-xs | ||
| 未解決 | ||
.page-nav__item-title | ||
= question.title | ||
.page-nav-metas | ||
.page-nav-metas__item | ||
= "公開:#{l question.published_at}" | ||
.page-nav-metas__item | ||
= "回答・コメント(#{question.answers.count})" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issueの町田さんとの確認内容の中で記載されていた「もっと見る」の文言から、「全て見る」の文言に変更した理由はありますか?
一般的には「もっと見る」の文言のほうが見る機会が多いかな?と思ったのと、遷移先ページでページネーションがあり必ず全件見られるわけではないので、気になりました。
(必ず修正すべきという意味ではなく、意図があればまずお聞きしたいなという感じです! もし特に意図がなければ「もっと見る」でいいのかなとは思いました。)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
町田さんにデザインを入れてもらった中で変更されてました。
Docsが「全て見る」になっていて、Q&Aもそれと合わせたのだと思っています。