Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

退会手続きページのタイトルから「休会」を外した #6243

Merged
merged 1 commit into from
Feb 25, 2023
Merged

退会手続きページのタイトルから「休会」を外した #6243

merged 1 commit into from
Feb 25, 2023

Conversation

djkazunoko
Copy link
Contributor

@djkazunoko djkazunoko commented Feb 18, 2023 •
edited
Loading

Issue

概要

退会手続きページのタイトルを「退会・休会手続き」から「退会手続き」に変更しました。
(休会手続きページが別にあるため)

変更確認方法

  1. feature/change-retirement-page-titleをローカルに取り込む
  2. rails sでサーバーを起動
  3. localhost:3000にアクセス
  4. kimuraでログイン
  5. /retirement/newにアクセス

Screenshot

変更前

issue_6147_before-1

変更後

issue_6147_after-1

@djkazunoko djkazunoko marked this pull request as ready for review February 18, 2023 07:03
@djkazunoko djkazunoko self-assigned this Feb 18, 2023
@djkazunoko
Copy link
Contributor Author

@shucream-p
お疲れ様です！
こちらのレビューをお願いしたいのですがご都合いかがでしょうか？

@shucream-p
Copy link
Contributor

@djkazunoko
お疲れ様です！
レビュー依頼ありがとうございます！
明日までに確認いたします〜🙏

@djkazunoko
Copy link
Contributor Author

@shucream-p
ありがとうございます！
よろしくお願いします🙇‍♂️

shucream-p
shucream-p approved these changes Feb 19, 2023
View reviewed changes
Copy link
Contributor

@shucream-p shucream-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djkazunoko
動作とコード確認いたしました！
Approveさせていただきます！👍

@djkazunoko
Copy link
Contributor Author

@shucream-p
レビューありがとうございました😊

@djkazunoko
Copy link
Contributor Author

@komagata
メンバーレビュー完了しましたので、レビューよろしくお願いいたします！

komagata
komagata approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認させて頂きました。OKです〜🙆‍♂️

@komagata komagata merged commit e9d95fa into main Feb 25, 2023
@komagata komagata deleted the feature/change-retirement-page-title branch February 25, 2023 08:34
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shucream-p shucream-p shucream-p approved these changes

@komagata komagata komagata approved these changes

Assignees

@djkazunoko djkazunoko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djkazunoko @shucream-p @komagata