Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop のルールStyle/HashSyntaxを一部に適用 #7295

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

kyokucho1989
Copy link
Contributor

@kyokucho1989 kyokucho1989 commented Jan 31, 2024

Issue

概要

Issue番号 #7280 を参考

変更確認方法

  1. {feature/apply-rubocop-rule-2}をローカルに取り込む
  2. rubocop を実行
  3. エラーが出ないことを確認する

Screenshot

特にありません。

@kyokucho1989 kyokucho1989 marked this pull request as ready for review February 1, 2024 03:35
@kyokucho1989
Copy link
Contributor Author

@kurumadaisuke
お疲れ様です。こちらのレビューをお願いしたいです!特に急いでません

@kurumadaisuke
Copy link
Contributor

@kyokucho1989
かしこまりました
確認しますー🙏

少々お時間もらうかもしれませんが見てみます🙇‍♂️

Copy link
Contributor

@kurumadaisuke kurumadaisuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyokucho1989
お待たせしました!OKです!
こちらのローカル環境でrobocop実行し、すべてクリアしたことを確認しました🙆‍♂️
お疲れ様です!

スクリーンショット 2024-02-03 14 39 43

@kyokucho1989
Copy link
Contributor Author

@kurumadaisuke
ありがとうございます!

@komagata
メンバーの方のレビューが終了しました。
レビューをお願いします!

@kyokucho1989 kyokucho1989 requested a review from komagata February 4, 2024 02:11
Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認させて頂きました。OKです〜🙆‍♂️

@komagata komagata merged commit 91f475d into main Feb 4, 2024
9 checks passed
@komagata komagata deleted the feature/apply-rubocop-rule-2 branch February 4, 2024 22:15
@github-actions github-actions bot mentioned this pull request Feb 4, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants