Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slim-lintの4ルールが適用できるか調査し反映する #7395

Merged
merged 3 commits into from
Feb 22, 2024
Merged

slim-lintの4ルールが適用できるか調査し反映する #7395

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88b8493
「Layout/IndentationConsistency」ルール削除、他コメント追加
a-terumoto-gs Feb 16, 2024
1f8b21f
#のあとに1スペース追加
a-terumoto-gs Feb 19, 2024
cccf454
#前の不要なスペース削除
a-terumoto-gs Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/slim_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ linters:
- Layout/MultilineOperationIndentation
- Layout/ParameterAlignment
- Layout/TrailingEmptyLines
- Lint/Void #除外検討したが見送り
- Metrics/BlockLength #除外検討したが見送り
- Lint/Void # 除外検討したが見送り
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Lint/Void # 除外検討したが見送り
- Lint/Void # 除外検討したが見送り

Copy link
Contributor Author

@a-terumoto-gs a-terumoto-gs Feb 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@komagata
確認が甘く、修正の爪が甘くて申し訳ございません。
3つとも#の前の不要なスペース1つを削除しました。

- Metrics/BlockLength # 除外検討したが見送り
- Metrics/BlockNesting
- Naming/FileName
- Style/FrozenStringLiteralComment #除外検討したが見送り
- Style/FrozenStringLiteralComment # 除外検討したが見送り
- Style/IdenticalConditionalBranches
- Style/IfUnlessModifier
- Style/Next
Expand Down