お知らせ通知用のジョブに例外処理を追加 #7540
Merged
お知らせ通知用のジョブに例外処理を追加 #7540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@komagata |
29 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
通知用のジョブの中に例外処理が抜けていたため、例えば特定のアドレスへの送信を失敗すると、ジョブ自体が中断され、以降の通知が送られていなかった。
変更確認方法
bug/add-exception-handling-to-announcement-jobをローカルに取り込むActivityMailer#post_announcementに以下のようなコードを追加）kimura以外のユーザーでお知らせを作成するgood_jobのダッシュボード（localhost:3000/good_job/jobs）へアクセスして、該当のJobがSucceededになっていることkimura以外に送られていることkimuraを含む全員へ送られていること