ユーザーのプロフィールページのtitleタグ内が、「{ユーザー名}さんのプロフィール」になるように修正 #7836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motohiro-mm
requested review from
kurumadaisuke and
Shrimprin
and removed request for
kurumadaisuke
|
@Shrimprin |
|
@motohiro-mm |
|
@Shrimprin |
Shrimprin
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
@motohiro-mm
確認しました！OKだと思いますのでapproveしました〜
確認方法がとてもわかりやすく書いてあって助かりました！👏
|
@Shrimprin @komagata |
komagata
deleted the
feature/correct-text-in-title-tag-of-user-profile-page
branch
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
ユーザーのプロフィールページのtitleタグ内が、「{ユーザー名}さんのプロフィール」になるように修正しました。
titleタグ：
{ユーザー名} | FBCog:title：
{ユーザー名}titleタグ：
{ユーザー名}さんのプロフィール | FBCog:title：
{ユーザー名}さんのプロフィールこの修正に伴いタブのタイトル表示も同様に修正されます。
変更確認方法
feature/correct-text-in-title-tag-of-user-profile-pageをローカルに取り込むforeman start -f Procfile.devでサーバーを立ち上げる<head>タグ内 の<title>タグ内が、(development) {ユーザー名}さんのプロフィール | FBCになっていること<head>タグ内の"og:title"プロパティのcontentが{ユーザー名}さんのプロフィールになっていること(development) {ユーザー名}さんのプロフィール | FBCになっていることブラウザのタブにカーソルを乗せるとタイトルが表示されます。
Screenshot
変更前
変更後