ユーザー個別ページのコメント一覧のtitleタグを修正 #7865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nishitatsu-dev |
|
@su-su-su-su |
|
ありがとうございます。 |
nishitatsu-dev
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
@su-su-su-su
動作とコード確認しました〜。勉強になりました。
LGTMなので、approveします！！！
細かい話ですみませんが、以下の2箇所を修正して先に進んで下さい〜🙏
- このプルリクのタイトルの、
titleのつづり - 変更確認方法に書いてあるブランチ名の、
commentのつづり
|
お忙しい中ご確認頂きありがとうございます。 気づけていなかった点をご指摘頂いてありがとうございます🙇 |
|
@su-su-su-su |
|
ご確認ありがとうございました🙇♂️ |
|
@komagata |
13 tasks
|
@komagata |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
titelタグ、og:titleのユーザー名がさん付けになるように修正しました。
変更確認方法
feature/correct-title-tag-user-comments-list-pageをローカルに取り込むforeman start -f Procfile.devでサーバーを立ち上げるマイプロフィールをクリックコメントをクリック○○さんのコメント一覧となっていることを確認 (development) はローカル環境時にだけ表示されるものなので無視○○さんのコメント一覧となっていることを確認Screenshot
変更前
変更後