Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

卒業生の声ページのheadタグを正しいものに修正した #8229

Merged
merged 2 commits into from
Dec 18, 2024
Merged

卒業生の声ページのheadタグを正しいものに修正した #8229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb73c39
alumni_voicesのheadタグを正しいものに
mousu-a Nov 28, 2024
afb0f05
alumni_voicesページのテストを追加
mousu-a Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/welcome/alumni_voices.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
- content_for :extra_body_classes, 'welcome'
- title 'FAQ'
- title '卒業生の声'
- set_meta_tags(site: 'FJORD BOOT CAMP（フィヨルドブートキャンプ）',
description: 'フィヨルドブートキャンプに寄せられたよくあるお問い合わせとその回答の一覧です。')
description: 'フィヨルドブートキャンプ卒業生のインタビューやプレゼンテーションの記事を紹介しています。')

article.lp
header.lp-content.is-lp-bg-main.is-hero
Expand Down
7 changes: 7 additions & 0 deletions test/system/welcome_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ class WelcomeTest < ApplicationSystemTestCase
assert_selector "meta[name='twitter:title'][content='アンチハラスメントポリシー']", visible: false
end

test 'GET /alumni_voices' do
visit '/alumni_voices'
assert_equal '卒業生の声 | FJORD BOOT CAMP（フィヨルドブートキャンプ）', title
assert_selector "meta[property='og:title'][content='卒業生の声']", visible: false
assert_selector "meta[name='twitter:title'][content='卒業生の声']", visible: false
end

test 'mentors can update their profiles' do
visit_with_auth '/current_user/edit', 'komagata'
attach_file 'user[profile_image]', Rails.root.join('test/fixtures/files/users/avatars/komagata.jpg'), make_visible: true
Expand Down
Loading