Explicit Exception for combined fit edge case #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting problem. I'll try to think of a solution, but in the meanwhile, your addition to the Exception seems to be quite helpful. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in combined fits that @PiaLJP had seen in the past and @matteo-dc ran into this week:
When doing a combined fit and one of the fit functions is just a constant then the shape casting fails and one gets an error. The solution we found in the past is to add
x * 0to the constant in the fit function to obtain the correct shape.This PR does not fix the issue as I wasn't able to come up with a good solution, yet. Instead, I added an explicit exception that informs the user and suggests our workaround. For the future, it would of course be desirable to correct the shape casting for this edge case.