Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo. #171

Closed
wants to merge 1 commit into from
Closed

Fixed typo. #171

wants to merge 1 commit into from

Conversation

abramobagnara
Copy link

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Run yarn start in the example folder to test your changes.
  5. Ensure the test suite passes (yarn test). It uses the example
  6. Update the readme if needed or the documentation
  7. Update the typescript definition is needed
  8. Make sure your code lints (yarn lint --fix).

Learn more about contributing here

Copy link
Owner

@fkhadra fkhadra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks a lot @abramobagnara

@Rheeseyb
Copy link

Please can this be merged? This is causing issues in webpack v5 and vite (it's the implicit cause of #174).

@sky0014
Copy link

sky0014 commented Oct 18, 2021

Met the same problem, home this to be merged.

@fkhadra
Copy link
Owner

fkhadra commented Nov 3, 2022

Dropping usage of process in upcoming release

@fkhadra fkhadra closed this Nov 3, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants