Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onClose delay #1179

Closed
jihea-park opened this issue Nov 27, 2024 · 3 comments
Closed

onClose delay #1179

jihea-park opened this issue Nov 27, 2024 · 3 comments
Labels
Merged in next Merged but not live

Comments

@jihea-park
Copy link

jihea-park commented Nov 27, 2024

Hi,

I know the onClose event handler has 1s delay because of transition.
But I think we need onCloseStart event handler to improve ui.

#685

I want to show Clear all button if toasts exist.
And not show the button if toast not exist....

Is there any solution about that?
Please help me.

@fkhadra
Copy link
Owner

fkhadra commented Nov 27, 2024

Hey @jihea-park, starting v11 #1178 onClose will be called as soon as the notification is closed and won't wait for the exit transition to complete

@fkhadra fkhadra added the Merged in next Merged but not live label Nov 27, 2024
@jihea-park
Copy link
Author

@fkhadra
WOW! AMAZINGGGGGGGG!!!!!!

@fkhadra fkhadra mentioned this issue Dec 10, 2024
@fkhadra
Copy link
Owner

fkhadra commented Dec 16, 2024

Hey @jihea-park, I've released a new major version, please read the release note before upgrading 🙏🏽

@fkhadra fkhadra closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged in next Merged but not live
Projects
None yet
Development

No branches or pull requests

2 participants