Mypy hook #1123
Open
Mypy hook #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jstucke
commented
Sep 1, 2023
•
jstucke
commented
- added mypy pre-commit hook
- added mypy config
- fixed all issues in the code base or at least added ignore comments where it wasn't possible
…arison ID type alias
…arison ID type alias
maringuu
requested changes
Sep 1, 2023
src/analysis/plugin/plugin.py
Outdated
| """Analyze a file. | ||
| May return None if nothing was found. | ||
|
|
||
| :param file_handle: :py:class:`io.FileIO` instance of the file to be analyzed | ||
| :param virtual_file_path: The virtual file paths, see :py:class:`~objects.file.FileObject` | ||
| :param analyses: A dictionary of dependent analysis | ||
|
|
||
| :return: The analysis if anything was found. | ||
| :return: The analysis results (if there are any). |
There was a problem hiding this comment.
nit: why use parentheses?
There was a problem hiding this comment.
In general? 😅
I don't know, if you want I can remove them. I originally just wanted to specify that analysis results are returned.
There was a problem hiding this comment.
I meant that what is written in the parentheses is useful information and reads better without the parantheses.
src/analysis/plugin/plugin.py
Outdated
| @@ -145,7 +149,7 @@ def get_analysis(self, file_handle: io.FileIO, virtual_file_path: dict, analyses | |||
| 'system_version': self.metadata.system_version, | |||
| 'summary': summary, | |||
| 'tags': tags_dict, | |||
| 'result': result.dict() if result else None, | |||
| 'result': result.dict() if isinstance(result, BaseModel) else None, | |||
There was a problem hiding this comment.
I think during the time I wasn't sure if the plugin always returns a BaseModel or if it can be a dict if no schema is specified. I think as it is now, the schema is mandatory and the plugin always returns a BaseModel, right?
maringuu
reviewed
Oct 2, 2023
| from multiprocessing import Value | ||
| from helperFunctions.types import MpValue, MpArray | ||
|
|
||
| pass |
maringuu
pushed a commit
to maringuu/FACT_core
that referenced
this pull request
Oct 12, 2023
maringuu
pushed a commit
that referenced
this pull request
Oct 18, 2023
maringuu
pushed a commit
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.