Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info leaks: added regex to find credentials in urls #1177

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Nov 23, 2023

No description provided.

@jstucke jstucke requested a review from dorpvom November 23, 2023 16:41
@jstucke jstucke self-assigned this Nov 23, 2023
@maringuu
Copy link
Collaborator

maringuu commented Aug 1, 2024

I fixed up the comment and cleaned up the history. Regarding code nothing was changed (diff).

Can you investigate the CI failure?

@jstucke
Copy link
Collaborator Author

jstucke commented Aug 2, 2024

Can you investigate the CI failure?

test_regression_virtual_file_path.test_unpacking_skip seems to be flaky again 😕
I will just restart the CI worker. We are already using a library for flaky tests and maybe we should just add that one 🙈

edit: this should probably fix it: #1243

@jstucke jstucke requested a review from maringuu August 2, 2024 13:56
@maringuu maringuu merged commit b9add22 into master Aug 8, 2024
10 checks passed
@maringuu maringuu deleted the creds-in-url-analysis branch August 8, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants