Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgres comments #1231

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

postgres comments #1231

wants to merge 1 commit into from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Jun 28, 2024

  • added table and column comments for documentation purposes and for displaying in the GraphiQL docs

ToDo:

  • generate alembic migration script

@jstucke jstucke requested a review from dorpvom June 28, 2024 13:47
@jstucke jstucke self-assigned this Jun 28, 2024
maringuu
maringuu reviewed Jul 8, 2024
View reviewed changes
src/storage/schema.py
index=True,
comment='The UID of the file object on which this analysis was performed.',
)
plugin = mapped_column(VARCHAR(64), nullable=False, comment='The name of the analysis plugin (e.g. "file_type").')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a personal style preference, I like to put every argument on its own regardless of the linelength.
Would you mind splitting the lines here too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maringuu maringuu maringuu left review comments

@dorpvom dorpvom Awaiting requested review from dorpvom

At least 1 approving review is required to merge this pull request.

Assignees

@jstucke jstucke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jstucke @maringuu