Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev autoruletester refactoring #594

Merged
merged 25 commits into from
Oct 23, 2024
Merged

Dev autoruletester refactoring #594

merged 25 commits into from
Oct 23, 2024

Conversation

Malutthias
Copy link
Collaborator

No description provided.

@Malutthias Malutthias added the refactoring only refactoring, no change in behavior label May 28, 2024
@Malutthias Malutthias requested a review from ppcad May 28, 2024 10:24
@Malutthias Malutthias force-pushed the dev_autoruletester_refactoring branch from df0b7ba to 79d9fec Compare July 16, 2024 15:01
Copy link
Collaborator

@ppcad ppcad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged main into the branch and done some minor refactoring (black, typing, docstrings).
However, it can't be merged, since the code quality is still to low for the linter. It needs to be above 9.5.
Can you please change it so that it can be merged?

@ppcad ppcad self-requested a review October 23, 2024 12:02
@Malutthias Malutthias marked this pull request as ready for review October 23, 2024 12:23
@ppcad ppcad merged commit 431ab54 into main Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring only refactoring, no change in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants