Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for extraVolumes and extraMounts #635

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Jul 18, 2024

populate volumes and mounts from value keys
adds logprep-cache-dir in memory volume and mounts it to /home/logprep/.cache

populate volumes and mounts from value keys
adds logprep-cache-dir in memory volume and mounts it to
/home/logprep/.cache
@ekneg54 ekneg54 added bug Something isn't working enhancement New feature or request labels Jul 18, 2024
@ekneg54 ekneg54 marked this pull request as ready for review July 18, 2024 08:04
@ekneg54 ekneg54 requested a review from herrfeder July 18, 2024 08:04
@ekneg54 ekneg54 self-assigned this Jul 18, 2024
@ekneg54 ekneg54 requested a review from djkhl July 18, 2024 08:05
Copy link
Collaborator

@herrfeder herrfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and even good documentation strings in the values.yaml file

@ekneg54 ekneg54 merged commit f06e3e4 into main Jul 18, 2024
12 checks passed
@ekneg54 ekneg54 deleted the dev-pseudonymizer-tmp-dir branch July 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants