Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ValueError@identity_elimination.py:226] ValueError: At least two variables in the identity group {eax_1#5 (type: char * aliased: False), eax_1#7 (type: char * aliased: False), ebx#0 (type: char * aliased: False), ebx#2 (type: char * aliased: False), eax_1#4 (type: char * aliased: False)} have out degree zero, namely eax_1#5 and eax_1#4, i.e., these set of vertices is not an identity group #388

Closed
bugfinder-bot opened this issue Feb 23, 2024 · 2 comments · Fixed by #389
Closed

[ValueError@identity_elimination.py:226] ValueError: At least two variables in the identity group {eax_1#5 (type: char * aliased: False), eax_1#7 (type: char * aliased: False), ebx#0 (type: char * aliased: False), ebx#2 (type: char * aliased: False), eax_1#4 (type: char * aliased: False)} have out degree zero, namely eax_1#5 and eax_1#4, i.e., these set of vertices is not an identity group #388

bugfinder-bot opened this issue Feb 23, 2024 · 2 comments · Fixed by #389
Assignees
@ebehner
Labels
bug Something isn't working bugfinder

Comments

@bugfinder-bot
Copy link
Collaborator

What happened?

  File "/opt/dewolf/decompiler/util/bugfinder/bugfinder.py", line 201, in iter_function_reports
    task_result = self.decompile(function, options)
  File "/opt/dewolf/decompile.py", line 51, in decompile
    pipeline.run(task)
  File "/opt/dewolf/decompiler/pipeline/pipeline.py", line 114, in run
    raise e
  File "/opt/dewolf/decompiler/pipeline/pipeline.py", line 107, in run
    instance.run(task)
  File "/opt/dewolf/decompiler/pipeline/dataflowanalysis/identity_elimination.py", line 313, in run
    variable_replacer.replace_variables(identity_group, identity_graph.find_replacement_variable_of_group(identity_group))
  File "/opt/dewolf/decompiler/pipeline/dataflowanalysis/identity_elimination.py", line 226, in find_replacement_variable_of_group
    raise ValueError(message)

Error class ValueError@identity_elimination.py:226 contains 88 cases.

How to reproduce?

python decompile.py 5981576009cd18282cad4eed8dbc33d8f2e7c7a7222c1de31ac6c1f4b8f3aff2 sub_40f84d --debug

sample: 5981576009cd18282cad4eed8dbc33d8f2e7c7a7222c1de31ac6c1f4b8f3aff2
case: https://bugfinder.seclab-bonn.de/case/25301/
dewolf commit: b26c6ed
Binaryninja version: 3.5.4526
@bugfinder-bot bugfinder-bot added bug Something isn't working bugfinder labels Feb 23, 2024
@ebehner ebehner self-assigned this Feb 23, 2024
@ebehner
Copy link
Collaborator

ebehner commented Feb 23, 2024

/cib

@github-actions GitHub Actions
Copy link
Contributor

Branch issue-388-ValueError_identity_elimination_py_226_ValueError_At_least_two_variables_in_the_identity_group_eax_1#5_type_char_aliased_False_eax_1#7_type_char_aliased_False_ebx#0_type_char_aliased_False_ebx#2_type_char_aliased_False_eax_1#4_type created!

github-actions bot added a commit that referenced this issue Feb 23, 2024
@github-actions
Create draft PR for #388
8ad3d35
@github-actions github-actions bot mentioned this issue Feb 23, 2024
Merged
@ebehner ebehner mentioned this issue Feb 23, 2024
Open
0x6e62 pushed a commit that referenced this issue Feb 26, 2024
@github-actions @ebehner
[ValueError@identity_elimination.py:226] ValueError: At least two var…
50d6b52 
…iables in the identity group {eax_1#5 (type: char * aliased: False), eax_1#7 (type: char * aliased: False), ebx#0 (type: char * aliased: False), ebx#2 (type: char * aliased: False), eax_1#4 (type: char * aliased: False)} have out degree zero, namely eax_1#5 and eax_1#4, i.e., these set of vertices is not an identity group (#389)

* Create draft PR for #388

* fix that it does not crash when the group is not a identity group

* add pytest

* fix format

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Eva-Maria Behner <eva-maria.behner@fkie.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebehner ebehner

Labels
bug Something isn't working bugfinder
Projects
None yet
Milestone
No milestone
2 participants
@ebehner @bugfinder-bot