New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid typescript interfaces #265

Merged

fkirc merged 1 commit into fkirc:master from abichinger:fix/invalid-ts-interface

May 22, 2024

Contributor

abichinger commented May 21, 2024

The generated Typescript interface for nested values is invalid.

e.g. the following json file

// en.json
{
  "state": {
    "ready": "Ready"
  }
}

will produce the following interface.

export interface AppLocalizations {
  state.ready: string  // the key state.ready should be enclosed in quotes
}


          Fix invalid typescript interfaces

f963995

fkirc approved these changes

View reviewed changes

Owner

fkirc left a comment

Lgtm

fkirc merged commit e36160b into fkirc:master

3 of 15 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet