-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce 'paths_filter' option and 'changed_files' output #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js v16 is current LTS and now supported as action runtime
Ready from my side 😃 |
The code looks good to me, let`s put it into master for community-testing 👍 |
Nice, thanks 👍 |
maximilianbraun
referenced
this pull request
in crossplane-contrib/xp-testing
Nov 17, 2023
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [fkirc/skip-duplicate-actions](https://github.com/fkirc/skip-duplicate-actions) | action | major | `v2.2.0` -> `v5.3.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>fkirc/skip-duplicate-actions (fkirc/skip-duplicate-actions)</summary> ### [`v5.3.1`](https://github.com/fkirc/skip-duplicate-actions/compare/v5.3.0...v5.3.1) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v5.3.0...v5.3.1) ### [`v5.3.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v5.3.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v5.2.0...v5.3.0) - Retry API requests on server errors by [@​paescuj](https://github.com/paescuj) in [https://github.com/fkirc/skip-duplicate-actions/pull/288](https://github.com/fkirc/skip-duplicate-actions/pull/288) - Update dependencies ### [`v5.2.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v5.2.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v5.1.0...v5.2.0) - Add a job summary by [@​paescuj](https://github.com/paescuj) in [https://github.com/fkirc/skip-duplicate-actions/pull/277](https://github.com/fkirc/skip-duplicate-actions/pull/277) - Cleanup README by [@​fkirc](https://github.com/fkirc) in [https://github.com/fkirc/skip-duplicate-actions/pull/278](https://github.com/fkirc/skip-duplicate-actions/pull/278) - Add graphical representation of backtracking-algorithm by [@​paescuj](https://github.com/paescuj) in [https://github.com/fkirc/skip-duplicate-actions/pull/279](https://github.com/fkirc/skip-duplicate-actions/pull/279) - Add FAQ section with solution for required matrix jobs by [@​paescuj](https://github.com/paescuj) in [https://github.com/fkirc/skip-duplicate-actions/pull/283](https://github.com/fkirc/skip-duplicate-actions/pull/283) - Update dependencies & rebuild by [@​paescuj](https://github.com/paescuj) in [https://github.com/fkirc/skip-duplicate-actions/pull/285](https://github.com/fkirc/skip-duplicate-actions/pull/285) ### [`v5.1.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v5.1.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v5.0.0...v5.1.0) Allow `release` for `do_not_skip` input ([https://github.com/fkirc/skip-duplicate-actions/pull/273](https://github.com/fkirc/skip-duplicate-actions/pull/273)) ### [`v5.0.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v5.0.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v4.0.0...v5.0.0) Various optimizations: - Check all inputs *before* doing any API requests - Stricter check for `doNotSkip` input - Exclude current workflow run from list of all workflow runs - Get rid of redundant and unnecessary lines - Add some explaining comments - Fix bug with empty `head_repository` - Action *might* be a bit faster 🚀 **Breaking changes:** - Previously, on input and API request errors the action might have exited successfully but with outputs `should_skip = false` and `reason = no_workflow_information`. Now, the action will exit with an error instead. To make sure that subsequent jobs will not be skipped in such cases it's recommended to set `continue-on-error: true` in the `skip-duplicate-actions` job. Note: This has already been recommended in the past regardless of this change. - The structure of the `skipped_by` output (also in `paths_filter`) has slightly changed for the sake of consistency and alignment with GitHub API: - `runId` is now `id` - `html_url` is now `htmlUrl` - Full example: ```json { "id": 1709469369, "runNumber": 737, "event": "pull_request", "treeHash": "e3434bb7aeb3047d7df948f09419ac96cf03d73e", "commitHash": "4a0432e823468ecff81a978165cb35586544c795", "status": "completed", "conclusion": "success", "htmlUrl": "https://github.com/fkirc/skip-duplicate-actions/actions/runs/1709469369", "branch": "master", "repo": "fkirc/skip-duplicate-actions", "workflowId": 2640563, "createdAt": "2022-01-17T18:56:06Z" } ``` Other changes: - Update dependencies **Full Changelog**: fkirc/skip-duplicate-actions@v4...v5.0.0 ### [`v4.0.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v4.0.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v3.4.1...v4.0.0) Advanced path-filtering and output options ([https://github.com/fkirc/skip-duplicate-actions/pull/181](https://github.com/fkirc/skip-duplicate-actions/pull/181)) ### [`v3.4.1`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v3.4.1) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v3.4.0...v3.4.1) Fix same_content_new bug (runs would be inappropriately skipped) ([https://github.com/fkirc/skip-duplicate-actions/pull/125](https://github.com/fkirc/skip-duplicate-actions/pull/125)) ### [`v3.4.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v3.4.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v3.3.0...v3.4.0) Disable cancellation by default ([#​93](https://github.com/fkirc/skip-duplicate-actions/issues/93)) ### [`v3.3.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v3.3.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v3.2.0...v3.3.0) Improve logging of paths-skipping ([#​80](https://github.com/fkirc/skip-duplicate-actions/issues/80)) ### [`v3.2.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v3.2.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v3.1.0...v3.2.0) Optional duplicate skipping ([#​74](https://github.com/fkirc/skip-duplicate-actions/issues/74)) ### [`v3.1.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v3.1.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v3.0.0...v3.1.0) Add an option to skip outdated runs ([https://github.com/fkirc/skip-duplicate-actions/pull/70](https://github.com/fkirc/skip-duplicate-actions/pull/70)) ### [`v3.0.0`](https://github.com/fkirc/skip-duplicate-actions/releases/tag/v3.0.0) [Compare Source](https://github.com/fkirc/skip-duplicate-actions/compare/v2.2.0...v3.0.0) Make concurrent skipping more powerful and easier to understand ([https://github.com/fkirc/skip-duplicate-actions/pull/66](https://github.com/fkirc/skip-duplicate-actions/pull/66)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/crossplane-contrib/xp-testing). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #159
Submitted as one PR since 'paths_filter' option and 'changed_files' output are closely connected. Hope that's okay for you, @fkirc!
Closes #139