Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect errors on missing flow value separators #350

Merged
merged 2 commits into from
May 27, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 26, 2024

This PR has added error detection of missing flow value separators ( , ) in flow containers and some test cases for the detection.
Before this PR, the deserializer mistakenly succeeded in parsing invalid YAML snippets which lacks necessary value separators, like the following:

# There must be a value separator between `123` and `true`.
foo: [123  true, 3.14]

# There must be a value separator between `123` and `qux`.
bar: {baz: 123  qux: false}

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label May 26, 2024
@fktn-k fktn-k added this to the Release v0.3.8 milestone May 26, 2024
@fktn-k fktn-k self-assigned this May 26, 2024
Copy link

github-actions bot commented May 26, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 2d7356c95682e8e7d794203b41efdee2f4f9baf2.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr350.zip
ID 1539333621
URL https://github.com/fktn-k/fkYAML/actions/runs/9247643918/artifacts/1539333621

@fktn-k fktn-k force-pushed the detect_error_on_missing_flow_value_separators branch from 556e40a to 2d7356c Compare May 27, 2024 01:07
@fktn-k fktn-k merged commit 48a55af into develop May 27, 2024
165 checks passed
@fktn-k fktn-k deleted the detect_error_on_missing_flow_value_separators branch May 27, 2024 01:25
This was referenced May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant