Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize lexer implementation #448

Merged
merged 6 commits into from
Dec 21, 2024
Merged

Optimize lexer implementation #448

merged 6 commits into from
Dec 21, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 21, 2024

In this PR, the lexer implementation has been optimized by reducing redundant object creations and data copies.
The effect of the optimization is shown by the updated benchmark results.

parsed file processed bytes per second (before) processed bytes per second (after)
ubuntu.yml 55.1393Mi/s 60.1886Mi/s
citm_catalog.json 82.9931Mi/s 91.1523Mi/s
citm_catalog.yml 35.152Mi/s 36.0492Mi/s

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Dec 21, 2024
@fktn-k fktn-k added this to the Release v0.4.1 milestone Dec 21, 2024
@fktn-k fktn-k self-assigned this Dec 21, 2024
Copy link

github-actions bot commented Dec 21, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 3794bd4eb3659a8da77480f844db53917b68e2a1.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr448.zip
ID 2352070340
URL https://github.com/fktn-k/fkYAML/actions/runs/12447063163/artifacts/2352070340

@fktn-k fktn-k merged commit 43a1884 into develop Dec 21, 2024
163 checks passed
@fktn-k fktn-k deleted the optimize_lexer_impl branch December 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant