Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: made sure that empty documents just serialize to [] or {} #460

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

johan-gson
Copy link
Contributor

Described in title. No test cases done.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@johan-gson johan-gson requested a review from fktn-k as a code owner January 8, 2025 20:25
Copy link

github-actions bot commented Jan 8, 2025

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit b323ccf1d00568033a4320843deff6d840e15fc5.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr460.zip
ID 2406391988
URL https://github.com/fktn-k/fkYAML/actions/runs/12688098039/artifacts/2406391988

@johan-gson
Copy link
Contributor Author

Ok, sorry, didn't realize you were using spaces, should be fixed now. Maybe now this is finally done? :)

Copy link
Owner

@fktn-k fktn-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close to the end...!

include/fkYAML/detail/output/serializer.hpp Outdated Show resolved Hide resolved
Copy link
Owner

@fktn-k fktn-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johan-gson
Looks good finally! Thanks a lot!

@johan-gson
Copy link
Contributor Author

johan-gson commented Jan 9, 2025 via email

@fktn-k fktn-k merged commit f6bae95 into fktn-k:develop Jan 9, 2025
163 checks passed
@fktn-k fktn-k added this to the Release v0.4.1 milestone Jan 9, 2025
@fktn-k fktn-k added the bug Something isn't working label Jan 9, 2025
@fktn-k
Copy link
Owner

fktn-k commented Jan 9, 2025

See also: issue #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants