Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UTF encode validation & line break normalization #470

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jan 21, 2025

This PR improves UTF encode validation and line break normalization for input buffers regarding both readability and performance, by removing unnecessary conditional branches and optimizing the way of scanning input buffer contents.
As for performance, see the updated benchmark results.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Jan 21, 2025
@fktn-k fktn-k added this to the Release v0.4.2 milestone Jan 21, 2025
@fktn-k fktn-k self-assigned this Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit a3590f87593df8f16bffb50f834817e7015c6c57.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr470.zip
ID 2463334628
URL https://github.com/fktn-k/fkYAML/actions/runs/12893178413/artifacts/2463334628

@fktn-k fktn-k force-pushed the refactor_input_validation_normalization branch from 081f99b to a3590f8 Compare January 21, 2025 18:11
@fktn-k fktn-k merged commit ee9bd5a into develop Jan 21, 2025
162 checks passed
@fktn-k fktn-k deleted the refactor_input_validation_normalization branch January 21, 2025 18:33
@fktn-k fktn-k mentioned this pull request Jan 22, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant