Remove urllib3 from requirements.txt #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents urllib3 being downgraded in my environment (nothing in flair depends on urllib3)
|
(closed and reopened PR to re-trigger Travis build) |
|
@jjjamie thanks for spotting and fixing this! tbh I don't remember why we needed to make the version explicit, but it seems to run now without so whatever conflict it caused seems to be resolved. Fewer dependencies is always a good thing, so I'll merge! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents urllib3 being downgraded in my environment (nothing in flair depends on urllib3)
At least I don't think it's needed... have I missed something? The line was added in 3336f8f