Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#21 Add more fields to dispatcher-service output #27

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

fratcliffe
Copy link
Contributor

@fratcliffe fratcliffe commented Nov 19, 2023

Adds more fields for dispatcher to send to submission and comment services

Closes #21

Changes made

  • Ignore line length in flake8
  • Address some flake8 indentation issues
  • submissions

    • Add 6 fields for dispatcher to send to submission service:
      author=submission.author.name,
      title=submission.title,
      selftext=submission.selftext,
      score=int(submission.score),
      upvote_ratio=int(submission.upvote_ratio),
      comment_count=int(submission.comments.__len__())
      
    • Add the new fields to the submission test:
      author="coolUser88", # test is failing on this field and I don't know why
      title="Woah, check this out!",
      selftext="beep boop, I am a submission",
      score=0,
      upvote_ratio=0,
      comment_count=0
      

Notes for the reviewer

  • The author field breaks the submission test - I'm still investigating this
  • I haven't added the comment fields yet, but I will do so :)
  • In order to test, you will need to get this PR branch: submission-service/pull/16 (I think I've given it the wrong branch name, I'm sorry :/

Checklist

  • Correct version increment expected (#patch/#minor/#major)
  • Tests updated (if applicable)
  • Docs updated (if applicable)

@fratcliffe fratcliffe marked this pull request as draft November 19, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more fields to the dispatcher service output
1 participant