👌 Use Offset type directly in JoystickAction.update calculations

flame-engine · Jan 17, 2021 · 7b884f9 · 7b884f9
1 parent 0889a29
commit 7b884f9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # CHANGELOG
 
 ## [next]
+ - Use `Offset` type directly in `JoystickAction.update` calculations
  - Changed `parseAnchor` in `examples/widgets` to throw an exception instead of returning null when it cannot parse an anchor name
  - Code improvements and preparing APIs to null-safety
  - BaseComponent removes children marked as shouldRemove during update

diff --git a/lib/components/joystick/joystick_action.dart b/lib/components/joystick/joystick_action.dart
@@ -136,15 +136,11 @@ class JoystickAction {
       // Calculate the knob position
       final double nextX = dist * cos(_radAngle);
       final double nextY = dist * sin(_radAngle);
-      final Offset nextPoint = Offset(nextX, nextY);
+      final nextPoint = Offset(nextX, nextY);
 
       if (_rectAction != null) {
-        final Offset diff = Offset(
-              _rectBackgroundDirection.center.dx + nextPoint.dx,
-              _rectBackgroundDirection.center.dy + nextPoint.dy,
-            ) -
-            _rectAction.center;
-
+        final diff =
+            _rectBackgroundDirection.center + nextPoint - _rectAction.center;
         _rectAction = _rectAction.shift(diff);
       }