feat: Add multiFactory to SpawnComponent #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
changed the title
spydon
reviewed
Jan 9, 2025
pcornelissen
force-pushed
the
multi-spawncomponent
branch
3 times, most recently
from
26244ea to
36be5da
Compare
…ponents for each spawn tick. For backwards compatibility the single component factory is still supported and wrapped internally.
pcornelissen
force-pushed
the
multi-spawncomponent
branch
from
36be5da to
e714216
Compare
|
The benchmark seems to be broken by itself ;) |
6 tasks
|
I did not close this! |
|
(I will rebase it though to see if my fix worked) |
spydon
approved these changes
Jan 9, 2025
|
You are welcome. Happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add multiFactory to SpawnComponent to be able to create a list of components for each spawn tick. For backwards compatibility the single component factory is still supported and wrapped internally.
Description
This PR enhances the SpawnComponent to accept a multiFactory which adds a list of components per tick instead of just one.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues