Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add direction and length getters and constructor to LineSegment #3446

Merged
merged 1 commit into from
Jan 15, 2025
Merged

feat: Add direction and length getters and constructor to LineSegment #3446

merged 1 commit into from
Jan 15, 2025

Conversation

luanpotter
Copy link
Member

Description

feat: Add direction and length getters and constructor to LineSegment

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@github-actions GitHub Actions
Copy link
Contributor

Benchmark Results

Package flame:

Benchmarks Current Branch
[luan.line1]		 Base Branch
[main]		 Diff
Render Components Benchmark 1148.432 μs 1147.650 μs 🔴 +0.068 %
Updating Components Benchmark 244910.889 μs 263745.500 μs 🟢 -7.141 %

Benchmarks provided with 💙 by Dart Benchmark Action.

@luanpotter luanpotter marked this pull request as ready for review January 15, 2025 05:25
@luanpotter luanpotter merged commit 7476357 into main Jan 15, 2025
9 checks passed
@luanpotter luanpotter deleted the luan.line1 branch January 15, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luanpotter @spydon