Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NineTileBoxComponent with HasPaint to enable effects #3459

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

spydon
Copy link
Member

@spydon spydon commented Jan 27, 2025

Description

This adds a possibility to override the paint in the NineTileBox class which enables NineTileBoxComponent to have HasPaint, so that opacity and color effects can be used on it.

Fixes: #3430

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Benchmark Results

Package flame:

Benchmarks Current Branch
[feat/ninetilebox-haspaint]
Base Branch
[main]
Diff
Render Components Benchmark 1170.895 μs 1175.719 μs 🟢 -0.410 %
Updating Components Benchmark 252835.125 μs 247219.778 μs 🔴 +2.271 %

Benchmarks provided with 💙 by Dart Benchmark Action.

@spydon spydon requested a review from erickzanardo January 27, 2025 10:45
@spydon spydon enabled auto-merge (squash) January 27, 2025 10:45
@spydon spydon requested a review from wolfenrain January 27, 2025 16:12
@spydon spydon merged commit d1340ad into main Jan 27, 2025
9 checks passed
@spydon spydon deleted the feat/ninetilebox-haspaint branch January 27, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NineTileBox Sprite Opacity
2 participants