Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Throw exception from parseAnchor in examples/widgets instead of returning null #632

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# CHANGELOG

## [next]
- Changed `parseAnchor` in `examples/widgets` to throw an exception instead of returning null when it cannot parse an anchor name
- Code improvements and preparing APIs to null-safety
- BaseComponent removes children marked as shouldRemove during update
- Use `find` instead of `globstar` pattern in `scripts/lint.sh` as the later isn't enabled by default in bash
Expand Down
12 changes: 5 additions & 7 deletions doc/examples/widgets/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Anchor parseAnchor(String name) {
return Anchor.bottomRight;
}

return null;
throw Exception("Cannot parse anchor name `$name`");
}

void main() async {
Expand Down Expand Up @@ -108,9 +108,8 @@ void main() async {
child: SpriteWidget(
sprite: shieldSprite,
anchor: parseAnchor(
ctx.listProperty('anchor', 'Anchor.center', anchorOptions),
) ??
Anchor.topLeft,
ctx.listProperty('anchor', 'Anchor.center', anchorOptions),
),
),
),
);
Expand All @@ -135,9 +134,8 @@ void main() async {
animation: _animation,
playing: ctx.boolProperty('playing', true),
anchor: parseAnchor(
ctx.listProperty('anchor', 'Anchor.center', anchorOptions),
) ??
Anchor.topLeft,
ctx.listProperty('anchor', 'Anchor.center', anchorOptions),
),
),
),
);
Expand Down