Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: used setters and getters for motorSpeed #58

Merged
merged 5 commits into from
May 14, 2022

Conversation

alestiago
Copy link
Collaborator

@alestiago alestiago commented May 13, 2022

Description

Removes setMotorSpeed and getMotorSpeed from RevoluteJoint, PrismaticJoint and WheelJoint in favour of dart's setters and getters.

The following snippet illustrates the API change.

joint.setMotorSpeed(2); // OLD
joint.motorSpeed = 2; // NEW

joint.getMotorSpeed(); // OLD
joint.motorSpeed; // NEW

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@alestiago
Copy link
Collaborator Author

@spydon , CI/CD seems to be failing. Updated #47 to fix this.

@spydon spydon self-requested a review May 13, 2022 13:23
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! A test that checks that the body is awake after setting the speed would be good too (for possible future regressions).

@spydon spydon merged commit 96103f1 into flame-engine:main May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants