Add missing loop over block columns of C #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the column count of C exceeds 1000, the code encounters a segmentation fault. The block size is defined #define nb 1000 and used to allocate the buffers. However, n instead of nb is passed. * add the missing loop over block columns of C * adjust the leading dimensions to select whatever the row count is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block column width of C is defined by
#define nb 1000and used to allocate the buffers, but otherwisenbis unused.As a result, if the m-by-n matrix C has
n>nb, the code encounters a segmentation fault. This commit fixes this issue by