-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flameshot doesn't work with sway #2109
Comments
Have you already followed this: https://github.com/flameshot-org/flameshot/blob/master/docs/Sway%20and%20wlroots%20support.md |
I didn't, but after doing all of the above mentioned steps it's still the same behaviour. |
works for me |
@Benibla124 i just realized you have not provided the full version info (or your Flameshot version is some months old) try force installing the AUR (e.g |
I tried with flameshot-git, still didn't change anything. |
Works for me with stable (0.10.2-1) as well - @Benibla124 are you sure you've got the dependencies installed? They're |
@RiedleroD Yeah, got them installed. |
@Benibla124 do you have notification manager? |
Just freshly installed sway on my new laptop; can now reproduce. I'll send an update once I figure out which dependency I need to install. |
I GOT IT someone explain this to me. |
wtf, didn't read that because that info is supposed to be in the package manager :/ edit: (no, it's not even in the optional deps) |
Sorry we don't control the packaging for upstream. |
ik, I'm sending the guy that packaged flameshot a mail rn |
I'm not sure how they would package it so grim is only requires on sway. Edit: maybe just needs to be put in the arch wiki entry. |
as I said, optional dependencies. They can even add an explanation for each optdep. (and that's one reason why I think arch is better than debian ;P) |
In the AUR I have added GRIM ages ago as optional dependency (check line 103): https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=flameshot-git |
Adding optional depends similar to Arch is also always possible on debian via Recommends or Suggests fields since the very beginning. The only part missing is the conditional-depends feature, which I think won't be available in near future. If package grim is useful to Sway users, we can update dependency fields in deb packages. The only question is that whether we should use the Recommends field or Suggests field:
I think using Suggests or Recommends may all be reasonable. |
@hosiet I would go with "Recommends" as it is not a massive library. |
Thanks, I have implemented it in Debian's flameshot (version 11.0~rc1+ds1-2). Please also see the Pull Request at #2212 . |
…#2212) See also: flameshot-org#2109 (cherry picked from commit f9745bb)
Flameshot Version
Flameshot v 0.10.1
Installation Type
User repository (AUR)
Operating System type and version
Arch Linux Rolling (Kernel 5.15.4)
Description
Flameshot starts, it does show the tray icon. Clicking it does nothing, the screenshot tool won't open.
Steps to reproduce
Screenshots or screen recordings
Here's the log:
https://bin.snopyta.org/?4cf0e34e4783de3f#HzdpEfg4EoEwDPLVvMzqETpPszKQKhwCxGQMGRrfaPVM
System Information
OS: Arch Linux x86_64
Host: Predator PH317-52 V1.26
Kernel: 5.15.4-arch1-1
Resolution: 1920x1080
WM: sway
CPU: Intel i7-8750H (12) @ 2.200GHz
GPU: Intel CoffeeLake-H GT2 [UHD Graphics 630]
GPU: NVIDIA GeForce GTX 1050 Ti Mobile
Memory: 2039MiB / 15842MiB
Using Wayland with sway.
The text was updated successfully, but these errors were encountered: