Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flameshot doesn't work with sway #2109

Closed
bblacher opened this issue Nov 24, 2021 · 20 comments
Closed

Flameshot doesn't work with sway #2109

bblacher opened this issue Nov 24, 2021 · 20 comments
Labels
Unconfirmed Bug The bug is not confirmed by anyone else. Waiting For Info Addressing the issue or merging the PR is halted and we are waiting for more info to be provided.

Comments

@bblacher
Copy link

Flameshot Version

Flameshot v 0.10.1

Installation Type

User repository (AUR)

Operating System type and version

Arch Linux Rolling (Kernel 5.15.4)

Description

Flameshot starts, it does show the tray icon. Clicking it does nothing, the screenshot tool won't open.

Steps to reproduce

  • Use sway
  • Run Flameshot
  • It won't work

Screenshots or screen recordings

Here's the log:
https://bin.snopyta.org/?4cf0e34e4783de3f#HzdpEfg4EoEwDPLVvMzqETpPszKQKhwCxGQMGRrfaPVM

System Information

OS: Arch Linux x86_64
Host: Predator PH317-52 V1.26
Kernel: 5.15.4-arch1-1
Resolution: 1920x1080
WM: sway
CPU: Intel i7-8750H (12) @ 2.200GHz
GPU: Intel CoffeeLake-H GT2 [UHD Graphics 630]
GPU: NVIDIA GeForce GTX 1050 Ti Mobile
Memory: 2039MiB / 15842MiB

Using Wayland with sway.

@bblacher bblacher added the Unconfirmed Bug The bug is not confirmed by anyone else. label Nov 24, 2021
@mmahmoudian
Copy link
Member

@mmahmoudian mmahmoudian added the Waiting For Info Addressing the issue or merging the PR is halted and we are waiting for more info to be provided. label Nov 24, 2021
@bblacher
Copy link
Author

I didn't, but after doing all of the above mentioned steps it's still the same behaviour.

@RiedleroD
Copy link
Contributor

works for me
I'm using current master and sway 1.6.1, no special workarounds.

@mmahmoudian
Copy link
Member

@Benibla124 i just realized you have not provided the full version info (or your Flameshot version is some months old) try force installing the AUR (e.g paru flameshot-git) and then give us the full version info which should contain the git commit hash as well.

@bblacher
Copy link
Author

I tried with flameshot-git, still didn't change anything.

@RiedleroD
Copy link
Contributor

Works for me with stable (0.10.2-1) as well - @Benibla124 are you sure you've got the dependencies installed? They're grim xdg-desktop-portal xdg-desktop-portal-wlr.

@bblacher
Copy link
Author

@RiedleroD Yeah, got them installed.

@mmahmoudian
Copy link
Member

@Benibla124 do you have notification manager?

@RiedleroD
Copy link
Contributor

Just freshly installed sway on my new laptop; can now reproduce. I'll send an update once I figure out which dependency I need to install.

@RiedleroD
Copy link
Contributor

I GOT IT
IT DEPENDS ON GRIM WHAT THE FUCK

someone explain this to me.

@RiedleroD
Copy link
Contributor

RiedleroD commented Dec 30, 2021

wtf, didn't read that because that info is supposed to be in the package manager :/

edit: (no, it's not even in the optional deps)

@borgmanJeremy
Copy link
Contributor

Sorry we don't control the packaging for upstream.

@RiedleroD
Copy link
Contributor

ik, I'm sending the guy that packaged flameshot a mail rn

@borgmanJeremy
Copy link
Contributor

borgmanJeremy commented Dec 30, 2021

I'm not sure how they would package it so grim is only requires on sway.

Edit: maybe just needs to be put in the arch wiki entry.

@RiedleroD
Copy link
Contributor

as I said, optional dependencies. They can even add an explanation for each optdep. (and that's one reason why I think arch is better than debian ;P)

@mmahmoudian
Copy link
Member

In the AUR I have added GRIM ages ago as optional dependency (check line 103):

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=flameshot-git

@hosiet
Copy link
Member

hosiet commented Dec 31, 2021

Adding optional depends similar to Arch is also always possible on debian via Recommends or Suggests fields since the very beginning. The only part missing is the conditional-depends feature, which I think won't be available in near future.

If package grim is useful to Sway users, we can update dependency fields in deb packages. The only question is that whether we should use the Recommends field or Suggests field:

  • Depends: echo to users during installation, installed by default; will fail if not exist
  • Recommends: echo to users during installation, installed by default; will not fail if user opt not to install
  • Suggests: echo to users during installation, not installed by default; will not fail if user opt not to install

I think using Suggests or Recommends may all be reasonable.

@mmahmoudian
Copy link
Member

@hosiet I would go with "Recommends" as it is not a massive library.

@hosiet
Copy link
Member

hosiet commented Dec 31, 2021

Thanks, I have implemented it in Debian's flameshot (version 11.0~rc1+ds1-2). Please also see the Pull Request at #2212 .

panpuchkov pushed a commit to namecheap/flameshot that referenced this issue Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unconfirmed Bug The bug is not confirmed by anyone else. Waiting For Info Addressing the issue or merging the PR is halted and we are waiting for more info to be provided.
Projects
None yet
Development

No branches or pull requests

5 participants