Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config option to disable grim warrning #3456

Merged

Conversation

Monirzadeh
Copy link
Contributor

@Monirzadeh Monirzadeh commented Dec 30, 2023

This PR attempts to fix annoying notification about Grim
close #3186
@mmahmoudian Should I add anything else? or any opinions?

@Monirzadeh
Copy link
Contributor Author

@mmahmoudian can you please review this one?

@mmahmoudian
Copy link
Member

Thanks for the PR. As an internal policy, I generally refrain from merging code changes before it is also approved by other devs. I asked other devs to review this issue on our Matrix channel (which you are also welcome to join). I will also tag them here to increase visibility:

@veracioux @panpuchkov @jack9603301

Copy link
Contributor

@jack9603301 jack9603301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to your PR, this PR doesn't seem to have any side effects. Instead, it will no longer output a grim warning message when the user wants to cancel the grim warning. Since this PR does not introduce any by-products, I will agree with this PR change

@mmahmoudian mmahmoudian added this to the v13 milestone May 22, 2024
@b0ch3nski
Copy link

There is a typo across all the code: Warnning -> Warning

@Monirzadeh
Copy link
Contributor Author

Thanks @b0ch3nski i fix that.

Copy link
Contributor

@jack9603301 jack9603301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, since this PR does not introduce any side effects, I will approve it

@mmahmoudian
Copy link
Member

mmahmoudian commented Jul 2, 2024

@Monirzadeh thanks for the PR. Would you please handle the clang format. I'll merge when that passes. 👍

clang-format -i $(git ls-files "*.cpp" "*.h")

Source: https://github.com/flameshot-org/flameshot/blob/master/docs/CONTRIBUTING.md#code

@mmahmoudian mmahmoudian merged commit ccb5a27 into flameshot-org:master Jul 2, 2024
23 checks passed
@mmahmoudian
Copy link
Member

@Monirzadeh thanks for the PR and clean code.
@jack9603301 thanks for the code review.

@Monirzadeh Monirzadeh deleted the flameshot-warning-config branch July 2, 2024 13:08
@killertofus
Copy link

I still see this
image

image
dwl, arch flameshot-git

@Monirzadeh
Copy link
Contributor Author

can you share flameshot.ini ?

@killertofus
Copy link

killertofus commented Jul 21, 2024

@Monirzadeh

[General]
contrastOpacity=188
drawColor=#800000
savePath=/home/killertofus/Pictures
uploadWithoutConfirmation=true 

@Monirzadeh
Copy link
Contributor Author

@killertofus
please add this to the config.

disabledGrimWarning=true

dose it solve the problem?

@killertofus
Copy link

yes @Monirzadeh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turning off the Flameshot warning
5 participants