-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config option to disable grim warrning #3456
config option to disable grim warrning #3456
Conversation
@mmahmoudian can you please review this one? |
Thanks for the PR. As an internal policy, I generally refrain from merging code changes before it is also approved by other devs. I asked other devs to review this issue on our Matrix channel (which you are also welcome to join). I will also tag them here to increase visibility: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to your PR, this PR doesn't seem to have any side effects. Instead, it will no longer output a grim warning message when the user wants to cancel the grim warning. Since this PR does not introduce any by-products, I will agree with this PR change
There is a typo across all the code: |
Thanks @b0ch3nski i fix that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, since this PR does not introduce any side effects, I will approve it
@Monirzadeh thanks for the PR. Would you please handle the clang format. I'll merge when that passes. 👍 clang-format -i $(git ls-files "*.cpp" "*.h") Source: https://github.com/flameshot-org/flameshot/blob/master/docs/CONTRIBUTING.md#code |
@Monirzadeh thanks for the PR and clean code. |
can you share |
|
@killertofus
dose it solve the problem? |
yes @Monirzadeh |
This PR attempts to fix annoying notification about Grim
close #3186
@mmahmoudian Should I add anything else? or any opinions?