-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update cis #3587
base: master
Are you sure you want to change the base?
Fix update cis #3587
Conversation
@@ -555,7 +563,7 @@ jobs: | |||
echo "================================" | |||
echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV | |||
- name: Packaging snap | |||
uses: snapcore/action-build@v1 | |||
uses: snapcore/action-build@v1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: snapcore/action-build@v1.2.0 | |
uses: snapcore/action-build@v1 |
v1
will install latest v1 version ;)
@@ -84,7 +90,7 @@ jobs: | |||
echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV | |||
|
|||
- name: Restore from cache and run vcpkg | |||
uses: lukka/run-vcpkg@v11 | |||
uses: lukka/run-vcpkg@v11.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: lukka/run-vcpkg@v11.5 | |
uses: lukka/run-vcpkg@v11 |
with: | ||
path: ./build/Qt/${{ matrix.qt_ver }}/${{ matrix.config.qt_arch_install }} | ||
key: ${{ runner.os }}-QtCache/${{ matrix.qt_ver }}/${{ matrix.config.qt_arch }} | ||
|
||
- name: Install Qt | ||
uses: jurplel/install-qt-action@v2 | ||
uses: jurplel/install-qt-action@v3.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: jurplel/install-qt-action@v3.3.0 | |
uses: jurplel/install-qt-action@v3 |
with: | ||
path: ./build/Qt | ||
key: ${{ runner.os }}-QtCache | ||
|
||
- name: Install Qt | ||
uses: jurplel/install-qt-action@v2 | ||
uses: jurplel/install-qt-action@v3.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: jurplel/install-qt-action@v3.3.0 | |
uses: jurplel/install-qt-action@v3 |
@Saibamen It is not clear in the Github documentation if there is a difference between In some workflows, they move their major version tag to the latest minor version (e.g Do you know how for example the |
|
I've updated everything to the latest minor or major version depending on if they have their major version tag following their latest stable minor version tag or not.
I have kept the
actions/upload-artifact
back in v3 because:v3
->v4
(more info)