Fix AllOfFilter
#52
Merged
Fix AllOfFilter
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous way, the value of `conjoined` was reset in the parent class (MultipleChoiceFilter), making it mandatory to provide the value as `True` when using the filter. Ex.: AllOfFilter(conjoined=True). With this change, omitting this declaration, `__init__` will fill in this value, and the exception continues to be raised when the passed value is False Additionally, a typo error was fixed.
joaodaher
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous way, the value of
conjoinedwas reset in the parent class MultipleChoiceFilter, making it mandatory to provide the value asTruewhen using the filter to work as expectedEx.:
With this change, when omtting this declaration, the
__init__will fillTrueinconjoined, and the exception continues to be raised when the passed value isFalse. Additionally, a typo error was fixed.