feat: support a initial (default) filter's value be a callable #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasgomide
force-pushed
the
lg-callable-filter-initial
branch
3 times, most recently
from
3f2e083 to
3b4f36f
Compare
joaodaher
approved these changes
Jun 21, 2024
lucasgomide
force-pushed
the
lg-callable-filter-initial
branch
2 times, most recently
from
69bd989 to
218dc6b
Compare
When the value is set by Field.initial, it turns into a list of lists because each field in the query parameters (set up at the Django view layer) defaults to being a list
Previosly the initial filter value only accept literal value, after this change it will accept a callable to process complex operations
lucasgomide
force-pushed
the
lg-callable-filter-initial
branch
from
218dc6b to
c8e900a
Compare
Ruff does not support multiple target versions; it only supports the minimum versions. Since we want to support Python 3.11 in CI, it is better to change the target version.
lucasgomide
force-pushed
the
lg-callable-filter-initial
branch
from
c8e900a to
3e453fd
Compare
joaodaher
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.