feat: make privilege levels selectable in values file #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elaborate-horse-ac1743 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
BrendanGalloway
force-pushed
the
983-priv-options
branch
from
9e40f82 to
7e2dd2d
Compare
BrendanGalloway
force-pushed
the
983-priv-options
branch
from
580af83 to
6809694
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+64
to
+76
| {{- define "canary-checker.containerSecurityContext" -}} | ||
| allowPrivilegeEscalation: {{- if eq ( lower .Values.privilegeMode ) "privileged" }}true{{- else }}false{{- end }} | ||
| {{- if has ( lower .Values.privilegeMode) ( list "privileged" "root" ) }} | ||
| runAsUser: 0 | ||
| runAsGroup: 0 | ||
| fsGroup: 0 | ||
| {{- if eq ( lower .Values.privilegeMode ) "privileged" }} | ||
| capabilities: | ||
| add: | ||
| - CAP_NET_RAW | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
The fsGroup setting belongs in the pod's securityContext block, not the container's. This is because file system group IDs are a pod-level configuration that applies to all containers. Consider moving this setting to a separate helper template that's included in the pod's securityContext section of the deployment manifest.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.