feat: add AsGoGetterURL() to connection #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/connection-go-getter
branch
from
28f13b6 to
b7bfe12
Compare
moshloop
reviewed
Oct 18, 2023
moshloop
reviewed
Oct 18, 2023
adityathebe
force-pushed
the
feat/connection-go-getter
branch
from
9968096 to
84f3037
Compare
adityathebe
force-pushed
the
feat/connection-go-getter
branch
from
2c42156 to
bf777ad
Compare
moshloop
reviewed
Oct 18, 2023
moshloop
reviewed
Oct 18, 2023
moshloop
reviewed
Oct 18, 2023
moshloop
reviewed
Oct 18, 2023
adityathebe
force-pushed
the
feat/connection-go-getter
branch
from
488a62c to
946e12c
Compare
adityathebe
commented
Oct 18, 2023
| envPrep.Env = append(envPrep.Env, fmt.Sprintf("AWS_SECRET_ACCESS_KEY=%s", c.Password)) | ||
|
|
||
| // credentialFilePath :="$HOME/.aws/credentials" | ||
| credentialFilePath := filepath.Join(".creds", "aws", fmt.Sprintf("cred-%d", rand.Intn(100000000))) |
There was a problem hiding this comment.
@moshloop using fs/FS wasn't possible because it seems to be read-only. Can't create new files or write to one.
adityathebe
force-pushed
the
feat/connection-go-getter
branch
from
946e12c to
a40b7ca
Compare
moshloop
reviewed
Oct 18, 2023
|
|
||
| type EnvPrep struct { | ||
| // Env is the connection credentials in environment variables | ||
| Env []string |
There was a problem hiding this comment.
What is the difference between envs and command envs ?
There was a problem hiding this comment.
Env would provide you the credentials as standalone env vars. You could use either env var or the config file.
moshloop
force-pushed
the
feat/connection-go-getter
branch
from
fe151f7 to
52d0bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.