Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new git connection type for connections #1459

Merged
merged 9 commits into from
Nov 27, 2023
Merged

feat: add new git connection type for connections #1459

merged 9 commits into from
Nov 27, 2023

Conversation

mainawycliffe
Copy link
Contributor

Closes #1449

@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 65c2887
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/6563b2ca3e098f0008360577
😎 Deploy Preview https://deploy-preview-1459--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 65c2887
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/6563b2cab83a1700080d3119
😎 Deploy Preview https://deploy-preview-1459--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 65c2887
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/6563b2caaa081e0008fd2252
😎 Deploy Preview https://deploy-preview-1459--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 1449-add-new-git-connection-type branch 2 times, most recently from 351f256 to 9cde22d Compare October 24, 2023 12:59
@mainawycliffe mainawycliffe force-pushed the 1449-add-new-git-connection-type branch 8 times, most recently from 651391b to 547468f Compare November 1, 2023 04:39
@moshloop
Copy link
Member

moshloop commented Nov 1, 2023

@mainawycliffe I can't see to save the form ?

@mainawycliffe
Copy link
Contributor Author

@moshloop Let me investigate

@mainawycliffe mainawycliffe force-pushed the 1449-add-new-git-connection-type branch from 547468f to 8c5ec58 Compare November 1, 2023 18:29
@moshloop
Copy link
Member

moshloop commented Nov 2, 2023

@mainawycliffe - The password doesn't seem to save - also if you specify a user/pass and then save and edit it shows you an empty ssh key, it should choose the value that is not null

  • i should also default to user/pass not ssh

@moshloop
Copy link
Member

moshloop commented Nov 2, 2023

Can we also update the user/pass style to the same as on the http form (extracting and resuing components as needed)

@mainawycliffe mainawycliffe force-pushed the 1449-add-new-git-connection-type branch 2 times, most recently from bf12fa3 to 775a481 Compare November 6, 2023 07:02
@moshloop
Copy link
Member

moshloop commented Nov 6, 2023

@mainawycliffe We now have a Username None/Basic that expands to username and password under username? It should just be Auth: None | Basic | SSH,

@mainawycliffe mainawycliffe force-pushed the 1449-add-new-git-connection-type branch from 775a481 to 78b7a33 Compare November 7, 2023 07:52
@moshloop
Copy link
Member

moshloop commented Nov 7, 2023

@mainawycliffe We also need to add a namespace (defaulting to default) to all the connection forms and the table

@mainawycliffe mainawycliffe force-pushed the 1449-add-new-git-connection-type branch 3 times, most recently from 1d11265 to 77145be Compare November 8, 2023 07:22
@moshloop
Copy link
Member

@mainawycliffe when editing the SSH connection of type config/secret - the radio for config/secret is not selected (although the name and key are visible)

@mainawycliffe mainawycliffe force-pushed the 1449-add-new-git-connection-type branch from 77145be to fd31ff8 Compare November 15, 2023 19:32
@mainawycliffe mainawycliffe force-pushed the 1449-add-new-git-connection-type branch 5 times, most recently from 53b1d1a to 7e6f1ed Compare November 20, 2023 09:54
@mainawycliffe mainawycliffe force-pushed the 1449-add-new-git-connection-type branch from 7e6f1ed to 65c2887 Compare November 26, 2023 21:04
@moshloop moshloop merged commit aff1fac into main Nov 27, 2023
12 of 14 checks passed
@moshloop moshloop deleted the 1449-add-new-git-connection-type branch November 27, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop moshloop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new "git" connection type
2 participants
@mainawycliffe @moshloop