2344-waitFor-should-show-up-on-the-UI #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mainawycliffe - this should be a duration dropdown e.g. 1m, 3m, 5m, 10m, 15m, 30m, 60m,4h,8h,1d,3d |
|
@moshloop shouldn't the duration be in nanoseconds? |
mainawycliffe
force-pushed
the
2344-waitFor-should-show-up-on-the-UI
branch
2 times, most recently
from
2f63334
to
e7feb3d
Compare
mainawycliffe
force-pushed
the
2344-waitFor-should-show-up-on-the-UI
branch
2 times, most recently
from
35cd26d
to
d53c126
Compare
mainawycliffe
force-pushed
the
2344-waitFor-should-show-up-on-the-UI
branch
from
d53c126
to
9b359f7
Compare
moshloop
reviewed
Oct 18, 2024
moshloop
reviewed
Oct 18, 2024
Fixes #2344 fix: update favicon path to reference root Update src/components/Forms/Formik/FormikDurationNanosecondsField.tsx Co-authored-by: Moshe Immerman <moshe@flanksource.com> fix: fix calculations
mainawycliffe
force-pushed
the
2344-waitFor-should-show-up-on-the-UI
branch
from
8a76229
to
da0edfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2344
Fixes #2349
Fixes #2357