Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new Slack module to send slack notifications #1325

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Aug 28, 2024

resolves: #923

  • needed quite a bit of refactoring because the templating of the notification title & body needs to be pushed to the very end of the pipeline instead of the very beginning. This is because now we need to template the message only after we've figured out the shoutrrr service we're sending to.

@adityathebe adityathebe marked this pull request as draft August 28, 2024 04:28
notification/send.go Outdated Show resolved Hide resolved
@adityathebe
Copy link
Member Author

image

@adityathebe adityathebe marked this pull request as ready for review August 28, 2024 12:35
* show labels
* change outgoing_channel to channel
@adityathebe adityathebe force-pushed the feat/slack-notification-enhancements branch from 325ad46 to c788742 Compare August 28, 2024 13:46
@moshloop moshloop merged commit 9b5a858 into main Aug 28, 2024
7 checks passed
@moshloop moshloop deleted the feat/slack-notification-enhancements branch August 28, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack Notifications - Support Blocks
2 participants