Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and implement iptables-wrapper-installer.sh #1318

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

Oats87
Copy link
Member

@Oats87 Oats87 commented Jun 26, 2020

#1317

Description

This PR implements the iptables-wrapper-installer.sh script from https://github.com/kubernetes-sigs/iptables-wrappers/

Release Note

Enable auto-switching between `iptables (nf_tables)` and `iptables (legacy)` in Flannel container image

@rikatz
Copy link

rikatz commented Jul 1, 2020

@Oats87 can you confirm putting iptables-wrappers works fine with CentOS 8? Do you need me to help testing this?

Thank you!!

@dmitry-irtegov
Copy link

dmitry-irtegov commented Jul 2, 2020

@Oats87 can you confirm putting iptables-wrappers works fine with CentOS 8? Do you need me to help testing this?

I tested this in mixed cluster with RHeL 7 and 8 nodes (the nftables issue is common to both CentOS and RHeL).
Pure flannel with this patch works (i.e. correctly autodetects iptables mode) and passes https://github.com/sapcc/kube-detective connectivity test.
Update: cni-canal with calico 3.14.1 also works.

@rikatz
Copy link

rikatz commented Jul 2, 2020

Great, let me know if you need some tests also. On a side note I wasn’t aware of that “detective” and will take a look :)

@Oats87 Oats87 force-pushed the iptables-wrapper-installer branch from 83430a7 to 70b1095 Compare July 9, 2020 15:44
@rajatchopra
Copy link
Contributor

@AleksandrNull Can you review this PR? Thanks.

@AleksandrNull
Copy link
Contributor

Looking into

@AleksandrNull
Copy link
Contributor

Looks good to me!

@AleksandrNull
Copy link
Contributor

@rajatchopra I think we should merge it.

@rajatchopra rajatchopra merged commit 98c6acd into flannel-io:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants