move crd installer to module sdk #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
ldmonster
added
enhancement
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
added 2 commits
January 15, 2025 16:33
juev
approved these changes
Jan 16, 2025
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
juev
approved these changes
Jan 20, 2025
added 2 commits
January 23, 2025 09:40
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
…-installer-from-module-sdk
juev
approved these changes
Jan 23, 2025
yalosev
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When we add ensure crd hooks to module-sdk - it depends of CRDsInstaller.
To stop import it from addon-operator, we moved it to module-sdk.
What this PR does / why we need it
It moves crd installer to module-sdk.
If we move library/utils functions to module-sdk - we can stop import addon-operator to every component.
This change consistent with SOLID
Special notes for your reviewer
If it's ok - we need to merge PR in module-sdk and merge this