Fix typo in README.md #486
Conversation
README.md
Outdated
| @@ -60,15 +60,14 @@ We use http://www.apache.org/licenses/LICENSE-2.0 | |||
| ### Spring Integration | |||
|
|
|||
| As the spring projects | |||
| [removed the embed mongo support in 2.7.0](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#springmongodbembeddedfeatures-configuration-property-removed) | |||
There was a problem hiding this comment.
Yes, they updated the comment in their new release .. but they started removing the dependency with version 2.7.x. So i would not change that.
There was a problem hiding this comment.
@michaelmosmann Spring Boot still seems to manage dependency for Embedded MongoDB in 2.7.x here: https://github.com/spring-projects/spring-boot/blob/2.7.x/spring-boot-project/spring-boot-dependencies/build.gradle#L340-L346
Am I missing something?
| you should consider to use one of these integration projects. | ||
| It should behave mostly like the original spring integration, but there are some minor differences: | ||
| - version in 'spring.mongodb.embedded.version' is used in package resolver and is not matched against version enum. | ||
| - 'spring.mongodb.embedded.features' is not supported (not the way to change the config of mongodb) | ||
|
|
||
| If you have any trouble in using them fell free to create an issue. | ||
|
|
||
| - [Spring 2.5.x](https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo.spring/tree/spring-2.5.x) |
There was a problem hiding this comment.
Spring 2.5.x and 2.6.x support is still there. So i would not change that.
There was a problem hiding this comment.
@michaelmosmann I didn't count its commercial support, but 2.5.x also has been EOLed even for commercial support. I'll reinstate the entry for 2.6.x, but please let me know if you still want 2.5.x to be reinstated, too.
There was a problem hiding this comment.
@izeye I do not provide commercial support for spring 2.5.x but there are still users out there using it. So i would leave it:)
README.md
Outdated
| - [Spring 2.7.x](https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo.spring/tree/spring-2.7.x) | ||
| - [Spring 3.0.x](https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo.spring/tree/spring-3.0.x) | ||
| - [Spring 3.0.x](https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo.spring/tree/spring-3.1.x) |
There was a problem hiding this comment.
The Label should be changed to Spring 3.1.x.
|
@michaelmosmann Thanks for the feedback! I applied it in ccb9ee4. |
|
@izeye had to make a new release (without any changes). So i got the last part of your commit already... |
|
@michaelmosmann Thanks! I updated as you suggested. |
|
@michaelmosmann Sorry, I missed your last comment. Then, there's nothing left except fixing a typo that I meant to include in this PR when opening it, but somehow I missed it. |
|
@izeye .. even if there is not much left i would like to thank for your time and effort.. :) |
This PR polishes the
README.mda bit.